Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump versions in law testing doc #4424

Merged
merged 3 commits into from
May 18, 2023
Merged

Bump versions in law testing doc #4424

merged 3 commits into from
May 18, 2023

Conversation

lenguyenthanh
Copy link
Member

@lenguyenthanh lenguyenthanh commented Apr 15, 2023 •
edited
Loading

Another thing I noticed is scalacheck-shapeless only supports Scala 2.x. I think we either:

  • remove it from the docs and add something like if you use scala2 you can use scalacheck-shapeless to make things easier
  • Or add Scala 2 only note when mention scalacheck-shapeless

@lenguyenthanh lenguyenthanh changed the title Bump version in law testing docs Bump versions in law testing doc Apr 15, 2023
armanbilge
armanbilge reviewed Apr 15, 2023
View reviewed changes
Copy link
Member

@armanbilge armanbilge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, good idea to mention Scala 2-only, either of those seems fine :)

@lenguyenthanh
Copy link
Member Author

lenguyenthanh commented Apr 15, 2023 •
edited
Loading

Yes, good idea to mention Scala 2-only, either of those seems fine :)

I picked the first option ;)

@armanbilge
Copy link
Member

Woop, sorry this sat 😅

@armanbilge armanbilge merged commit 9012ebf into typelevel:main May 18, 2023
@lenguyenthanh lenguyenthanh deleted the patch-1 branch May 18, 2023 16:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@armanbilge armanbilge armanbilge approved these changes

Assignees
No one assigned
Labels
documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lenguyenthanh @armanbilge