Update sbt-doctest to 0.7.0 #1821
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1821 +/- ##
=======================================
Coverage 94.96% 94.96%
=======================================
Files 241 241
Lines 4193 4193
Branches 109 109
=======================================
Hits 3982 3982
Misses 211 211Continue to review full report at Codecov.
|
peterneyens
approved these changes
Aug 17, 2017
kailuowang
reviewed
Aug 28, 2017
build.sbt
Outdated
| scalaJSOptimizerOptions := scalaJSOptimizerOptions.value.withBatchMode(isTravisBuild.value), | ||
| doctestGenTests := Seq.empty, | ||
| doctestWithDependencies := false | ||
| wptions.value.withBatchMode(isTravisBuild.value), |
There was a problem hiding this comment.
looks like github's merge tool got this wrong. this line should be
scalaJSOptimizerOptions := scalaJSOptimizerOptions.value.withBatchMode(isTravisBuild.value),@fthomas can you update it?
There was a problem hiding this comment.
I've rebased the commit onto master.
`doctestWithDependencies` has been removed upstream since the plugin does not automatically add dependencies anymore.
fthomas
force-pushed
the
sbt-doctest-0.7.0
branch
from
cf685d6 to
509268b
Compare
LukaJCB
pushed a commit
to LukaJCB/cats
that referenced
this pull request
Sep 1, 2017
`doctestWithDependencies` has been removed upstream since the plugin does not automatically add dependencies anymore.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
doctestWithDependencieshas been removed upstream since the plugindoes not automatically add dependencies anymore.