Skip to content

Conversation

najuna-brian
Copy link

@najuna-brian najuna-brian commented Oct 16, 2025

Description

Adds binary-compatible methods for setting absolute time in TestControl:

  • setTime(targetTime): Sets clock to specified absolute time
  • advanceTo(targetTime): Alias for setTime with descriptive name

Both methods fail with IllegalArgumentException if target time is before current time.
Fixes the need for absolute time setting in TestControl, complementing the existing incremental advance() methods.

Why This Approach

This addresses the binary compatibility concerns raised in #4506 by adding new methods instead of modifying existing method signatures. Provides the same functionality as the clockStart parameter approach but maintains backward compatibility.

Refs #3309

@najuna-brian
Copy link
Author

Hi @armanbilge, @samspills

Please have a look at this when you have some time and guide accordingly. Thank you 😊

@najuna-brian najuna-brian marked this pull request as ready for review October 17, 2025 12:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant