Update vim/neovim plugins for hole punching (4/5) #97
Conversation
| @@ -72,17 +72,17 @@ def _start_agent(self): | |||
| ]) | |||
| self._agent_stdout_iter = iter(self._agent.stdout.readline, b"") | |||
|
|
|||
| message = None | |||
There was a problem hiding this comment.
You don't need this line I believe - the variable is declared inside an if/else block - since it always is declared, will be in scope after the block as well.
There was a problem hiding this comment.
Makes sense - will remove.
| @@ -280,17 +280,13 @@ def _handle_apply_patches(self, message): | |||
| def _handle_message(self, message): | |||
| self._message_handler(message) | |||
|
|
|||
| def start(self, host_ip=None, host_port=None): | |||
| def start(self, session_id=None): | |||
There was a problem hiding this comment.
Since the agent still supports the 'old'/direct way of connecting (I think?), we'll wan't to keep both options open here too. But we can do that later on.
There was a problem hiding this comment.
Yeah that's true. I think we should support it as a separate command so we can use it for debugging purposes as well. I'll create an issue.
There was a problem hiding this comment.
Should we even bother with exposing the old way? It's just more hassle/things to support.
There was a problem hiding this comment.
If anything it's useful for debugging 🤷♂️. Since otherwise the rendezvous server needs to be running. It didn't require much effort to support both ways of connecting on the agent so if anything #99 is a nice-to-have.
geoffxy
force-pushed
the
gy-editor-rdv
branch
from
859986e
to
97fa939
Compare
geoffxy
changed the title
geoffxy
force-pushed
the
gy-connection-states
branch
from
5d9e166
to
c661149
Compare
geoffxy
force-pushed
the
gy-editor-rdv
branch
from
97fa939
to
9918df7
Compare
These are changes for vim and neovim to support hole punching. I only made changes to these editors since it was to test end-to-end locally.
:Tandemnow sends theHostSessionmessage to the agent. The plugin will then print the session ID when it receives it from the agent.:Tandem <session-id>now sends theJoinSessionmessage to the agent.We can potentially also explore a way to add bindings for the plugin to send the
ConnectTomessage as well if we want (since the agent still has the ability to "connect" directly to another agent).