Skip to content

fix(core): remove some incorrect type assertions #826

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 18, 2025
Merged

fix(core): remove some incorrect type assertions #826

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
815fe20
fix(core): remove some incorrect type assertions
ocavue Jun 18, 2025
c399926
chore: remove unused imports
ocavue Jun 18, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 3 additions & 4 deletions packages/typedoc-plugin-markdown/src/theme/context/partials/container.body.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,6 @@ import {
} from '@plugin/theme/lib/index.js';
import {
ContainerReflection,
DeclarationReflection,
ReflectionGroup,
ReflectionKind,
} from 'typedoc';
Expand Down Expand Up @@ -54,7 +53,7 @@ export function body(
} else {
md.push(
this.partials.members(
group.children as DeclarationReflection[],
group.children.filter(child => child.isDeclaration()),
{
headingLevel: options.headingLevel,
},
Expand Down Expand Up @@ -83,9 +82,9 @@ export function body(
children: model.children,
} as ReflectionGroup),
);
} else {
} else if (model.children) {
md.push(
this.partials.members(model.children as DeclarationReflection[], {
this.partials.members(model.children, {
headingLevel: options.headingLevel,
}),
);
Expand Down
7 changes: 3 additions & 4 deletions packages/typedoc-plugin-markdown/src/theme/context/partials/container.categories.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,6 @@ import {
sortNoneSectionFirst,
} from '@plugin/theme/lib/index.js';
import {
DeclarationReflection,
ReflectionCategory,
ReflectionKind,
} from 'typedoc';
Expand All @@ -26,9 +25,9 @@ export function categories(
}
md.push(this.partials.groupIndex(category));
} else {
const categoryChildren = category.children?.filter(
const categoryChildren = category.children.filter(
(child) => child.kind !== ReflectionKind.Constructor,
);
).filter(child => child.isDeclaration());
if (categoryChildren.length) {
if (!isNoneSection(category)) {
md.push(heading(options.headingLevel, category.title));
Expand All @@ -37,7 +36,7 @@ export function categories(
md.push(this.helpers.getCommentParts(category.description));
}
md.push(
this.partials.members(categoryChildren as DeclarationReflection[], {
this.partials.members(categoryChildren, {
headingLevel: isNoneSection(category)
? options.headingLevel
: options.headingLevel + 1,
Expand Down
7 changes: 3 additions & 4 deletions packages/typedoc-plugin-markdown/src/theme/context/partials/container.groups.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,6 @@ import {
} from '@plugin/theme/lib/index.js';
import {
ContainerReflection,
DeclarationReflection,
i18n,
ProjectReflection,
ReflectionKind,
Expand Down Expand Up @@ -97,7 +96,7 @@ export function groups(
) {
md.push(
this.partials.propertiesTable(
group.children as DeclarationReflection[],
group.children.filter(child => child.isDeclaration()),
{
isEventProps,
kind: options.kind,
Expand All @@ -107,13 +106,13 @@ export function groups(
} else if (isEnumGroup && this.helpers.useTableFormat('enums')) {
md.push(
this.partials.enumMembersTable(
group.children as DeclarationReflection[],
group.children.filter(child => child.isDeclaration()),
),
);
} else {
if (group.children) {
md.push(
this.partials.members(group.children as DeclarationReflection[], {
this.partials.members(group.children.filter(child => child.isDeclaration()), {
headingLevel: isNoneSection(group)
? options.headingLevel
: options.headingLevel + 1,
Expand Down
4 changes: 2 additions & 2 deletions packages/typedoc-plugin-markdown/src/theme/context/partials/container.members.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,8 +14,8 @@ export function members(
}
return true;
};
const items = model?.filter((item) => !this.router.hasOwnDocument(item));
items?.forEach((item, index) => {
const items = model.filter((item) => !this.router.hasOwnDocument(item));
items.forEach((item, index) => {
md.push(
this.partials.memberContainer(item, {
headingLevel: options.headingLevel,
Expand Down
6 changes: 3 additions & 3 deletions packages/typedoc-plugin-markdown/src/theme/context/partials/member.groupIndex.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,18 +19,18 @@ export function groupIndex(group: ReflectionGroup | ReflectionCategory) {
if (this.options.getValue('indexFormat').toLowerCase().includes('table')) {
return getGroupIndexTable(
this,
group.children as DeclarationReflection[] | DocumentReflection[],
group.children,
);
}
return getGroupIndexList(
this,
group.children as DeclarationReflection[] | DocumentReflection[],
group.children,
);
}

export function getGroupIndexList(
context: MarkdownThemeContext,
children: DeclarationReflection[] | DocumentReflection[],
children: (DeclarationReflection | DocumentReflection)[],
) {
const filteredChildren =
children
Expand Down