Make AddRelatedManagers look for "objects" on parent model #730
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RJPercival
force-pushed
the
inherited_objects
branch
from
9c5bb82 to
e28a390
Compare
sobolevn
reviewed
Oct 18, 2021
RJPercival
force-pushed
the
inherited_objects
branch
from
e28a390 to
8c15713
Compare
|
Looks like CI is broken @sobolevn. |
RJPercival
force-pushed
the
inherited_objects
branch
from
8c15713 to
5bb5304
Compare
|
I am also fixing the CI failure in #734 🙂 |
RJPercival
force-pushed
the
inherited_objects
branch
from
5bb5304 to
e6663a1
Compare
Fails with: ``` pytest_mypy_plugins.utils.TypecheckAssertionError: Invalid output: Expected: main:2: note: Revealed type is "myapp.models.MyUser*" main:3: note: Revealed type is "myapp.models.MyUser*" <45 (diff) <45 (diff) Actual: main:2: note: Revealed type is "myapp.models.MyUser*" main:3: note: Revealed type is "myapp.models.MyUser*" main:6: error: "MyUser" has no attribute "book_set" (diff) main:6: note: Revealed type is "Any" (diff) main:7: error: "MyUser" has no attribute "article_set" (diff) main:7: note: Revealed type is "Any" (diff) ```
Previously, AddRelatedManagers would fail if a related model had inherited its `objects` field from a parent class. This would result in missing relation attributes. This is fixed by using `get()` instead of `names`; the former searches the MRO for the symbol, whereas the latter only looks for symbols declared directly on the class.
RJPercival
force-pushed
the
inherited_objects
branch
from
e6663a1 to
2f36af8
Compare
sobolevn
approved these changes
Oct 19, 2021
|
No problem 🙂 Any idea when the next release is likely to be? |
|
We need to fix #725 before releasing a new one 😞 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, AddRelatedManagers would fail if a related model had inherited its
objectsfield from a parent class. This would result in missing relation attributes. This is fixed by usingget()instead ofnames; the former searches the MRO for the symbol, whereas the latter only looks for symbols declared directly on the class.Related issues
Closes #652