Tests: Update to Django 6.0; fall back to 5.2 on Python <3.12 #2939
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Affects `tests` dependency group only.
intgr
changed the title
intgr
changed the title
Collaborator
Author
It worked! 🤯 🥳 |
intgr
commented
Dec 9, 2025
| Book.objects.create(id=None) # E: Incompatible type for "id" of "Book" (got "None", expected "float | int | str | Combinable") [misc] | ||
| Book.objects.create(publisher=None) # E: Incompatible type for "publisher" of "Book" (got "None", expected "Publisher | Combinable") [misc] | ||
| Book.objects.create(publisher_id=None) # E: Incompatible type for "publisher_id" of "Book" (got "None", expected "Combinable | int | str") [misc] | ||
| Book.objects.create(publisher_id=None) # E: Incompatible type for "publisher_id" of "Book" (got "None", expected "float | int | str | Combinable") [misc] |
Collaborator
Author
There was a problem hiding this comment.
This is a bit surprising -- where does this float come from? But I don't care enough to spend more time on it, seems mostly harmless.
sobolevn
reviewed
Dec 9, 2025
Member
sobolevn
left a comment
sobolevn
left a comment
There was a problem hiding this comment.
Great stuff!
Now we should decide if we are ready to jump into 6.0 support cicle. If we are - merge this right ahead!
Collaborator
Author
We don't necessarily want to advertise official Django 6.0 support yet. Not until we have more of the new APIs covered. But this should be merged regardless -- it's crucial to at least begin work on adding 6.0 APIs. |
Collaborator
Author
|
@UnknownPlatypus Do you want to take a look as well? |
UnknownPlatypus
approved these changes
Dec 10, 2025
This was referenced Dec 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
testsdependency group.allowlist_todo_django60.txtfile.