Remove str from enum label types when we know for sure the labels are lazy
#2888
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
Thanks for the improvement! I completely overlooked that we can be more specific here. 😅 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have made things!
Improves the mypy plugin to drop
strfrom the types of labels created viagettext_lazy.Instead of calculating and passing around a
boolindicating whether an enum has any lazy label, the code now calculates a_LabelLazinessenum with three members -LAZY,NON_LAZY, andMIXED- and dropsstrfrom the label type for_LabelLaziness.LAZY.Related issues
Closes #2887