Add type-checking to Manager.acreate #2477
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vitosamson
changed the title
sobolevn
reviewed
Jan 10, 2025
| import asyncio | ||
| from myapp.models import User | ||
| async def amain() -> None: | ||
| await User.objects.acreate(pk=1, name='Max', age=10) |
There was a problem hiding this comment.
Suggested change
| await User.objects.acreate(pk=1, name='Max', age=10) | |
| reveal_type(await User.objects.acreate(pk=1, name='Max', age=10)) |
sobolevn
approved these changes
Jan 10, 2025
|
Thanks @sobolevn! Any idea when this might go out in a release? |
|
We do releases every couple of month. I think that somewhere before / around the start of Feb. |
|
@flaeppe oh, I double checked. Our latest release was in Oct. So, maybe we can do one? |
|
That would be great since this issue caused us to miss a bug. I saw in the contributing docs that anybody can open the release PR - I'm happy to get that ball rolling if it would help. |
|
@vitosamson please, go ahead :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds type-checking to kwargs for the
.acreate()method. Currently.create()is type-checked but.acreate()is not.Related issues
Closes #2090
This is my first time diving into this codebase so let me know if I missed anything. I used the test case from #2093.