Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extend _AllLimitChoicesTo #2456

Merged

Conversation

H4rryK4ne
Copy link
Contributor

allow callables which return _LimitChoicesTo

I have made things!

Related issues

allow callables which return _LimitChoicesTo
@H4rryK4ne
Copy link
Contributor Author

I have 2 failing test, but they already fail on the master branch:

=========================================================================================== short test summary info ============================================================================================
FAILED tests/typecheck/contrib/gis/test_fields.yml::fields_getter_and_setter - 
FAILED tests/typecheck/models/test_inheritance.yml::django_contrib_gis_base_model_mixin_inheritance - 
================================================================================== 2 failed, 444 passed in 482.32s (0:08:02) ===================================================================================

Both test fail with

A: Error constructing plugin instance of NewSemanalDjangoPlugin

Copy link
Member

@sobolevn sobolevn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, what tests are failing? I cannot see any failures here: https://github.com/typeddjango/django-stubs/commits/master/

@H4rryK4ne
Copy link
Contributor Author

Sorry, what tests are failing? I cannot see any failures here: https://github.com/typeddjango/django-stubs/commits/master/

Sorry ... I meant, they where failing on my machine ...

Copy link
Member

@sobolevn sobolevn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@sobolevn sobolevn merged commit f75e52b into typeddjango:master Dec 5, 2024
40 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

Error on Field.limit_choices_to with callable
2 participants