Make BaseEngine.app_dirname non-optional
#2394
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Evidence that `app_dirname` should not be `None`: - all of the template engines inside Django set `app_dirname` to a string - `BaseEngine.template_dirs` passes the value of `app_dirname` to `get_app_template_dirs()`, which concatenates it to a `Path`
sobolevn
approved these changes
Oct 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Evidence that
app_dirnameshould not beNone:app_dirnameto a stringBaseEngine.template_dirspasses the value ofapp_dirnametoget_app_template_dirs(), which concatenates it to aPathOnly documentation I could find was this example, which also assigns a string to
app_dirname.