feat: Add missing stubs #2348
Merged
feat: Add missing stubs #2348
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sobolevn
reviewed
Aug 21, 2024
django-stubs/contrib/auth/forms.pyi
Outdated
| @@ -15,6 +15,8 @@ from typing_extensions import TypeAlias | |||
| UserModel: TypeAlias = type[_UserModel] | |||
| _User = TypeVar("_User", bound=AbstractBaseUser) | |||
|
|
|||
| def _unicode_ci_compare(s1: str, s2: str) -> bool: ... | |||
There was a problem hiding this comment.
We generally tend to ignore protected names in stubs. Can you please explain the use-case for this one?
There was a problem hiding this comment.
Hi 👋
I made use of that function in a project and noticed the type information was missing in my editor.
I did consider just copying the function into my code given it is so small.
I can amend the commit without this stub if you like.
Add stubs for django.contrib.auth.decorators::login_not_required
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds stubs for
login_not_requiredwhich is new in django 5.1 and the_unicode_ci_comparefunction in thedjango.contrib.auth.formsmodule.