Don't modify return values of manager methods in place, modify a copy instead #2345
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have made things!
#2343 and #1917 seem to be caused by
_process_dynamic_method
modifying the return types of QuerySet methods, while they're still being referenced by the base QuerySet class's methods. This works fine the first time a method's type is resolved, but since it modifies the base QuerySet's return value too (if it's a Union or something like list[T]), it gets rid of the TypeVar on the base QuerySet class. When we try to resolve the return type again from another manager from another model, the Generic is no longer there and we end up with whatever first replaced that Generic.Creating a copy seems to fix it, but then again, I have no idea what I'm doing 🤷
Related issues