Enable mypy.plugins.proper_plugin
#2333
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sobolevn
approved these changes
Aug 10, 2024
| @@ -20,7 +20,8 @@ force_union_syntax = true | |||
|
|
|||
|
|
|||
| plugins = | |||
| mypy_django_plugin.main | |||
| mypy_django_plugin.main, | |||
| mypy.plugins.proper_plugin | |||
There was a problem hiding this comment.
Thanks! I 100% forgot about it 😆
But, using it in django-stubs was my motivation for adding it to the mypy. namespace!
There was a problem hiding this comment.
Haha, yeah I happened to come across the documentation and started checking it out
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refs: https://mypy.readthedocs.io/en/stable/extending_mypy.html#useful-tools
This resulted in quite a lot of changes.. I think there are multiple places in our plugin functions where we should use
ProperTypeas return type instead ofMypyType(our alias formypy.types.Type), which could perhaps remove a couple ofget_proper_type.Not at all sure how much impact this could have, if any.