Add Typing for EmailField with Support for String Set and Get Types #2317
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sobolevn
reviewed
Aug 4, 2024
Comment on lines
360
to
361
| _pyi_private_set_type: str | Combinable | ||
| _pyi_private_get_type: str |
There was a problem hiding this comment.
Suggested change
| _pyi_private_set_type: str | Combinable | |
| _pyi_private_get_type: str | |
| _pyi_private_set_type: str | Combinable |
Since CharField already has _pyi_private_get_type: str set.
|
@sobolevn Removed the duplication, thanks for your help!) |
sobolevn
requested changes
Aug 4, 2024
| @@ -13,9 +13,9 @@ from django.db.models.sql.subqueries import AggregateQuery, DeleteQuery, InsertQ | |||
| from django.utils.functional import cached_property | |||
| from typing_extensions import TypeAlias | |||
|
|
|||
| _ParamT: TypeAlias = str | int | |||
| _ParamT: TypeAlias = Any | |||
There was a problem hiding this comment.
This does not look related to EmailFiled change
There was a problem hiding this comment.
Data from another PR accidentally got here, I'm sorry)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have made things!
Related issues
Closes #2212