Declare ManyToManyField.description a _StrOrPromise
#2312
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sobolevn
approved these changes
Aug 2, 2024
sobolevn
reviewed
Aug 2, 2024
| @@ -242,7 +242,7 @@ _Through = TypeVar("_Through", bound=Model) | |||
| _To = TypeVar("_To", bound=Model) | |||
|
|
|||
| class ManyToManyField(RelatedField[Any, Any], Generic[_To, _Through]): | |||
| description: str | |||
| description: _StrOrPromise | |||
There was a problem hiding this comment.
Maybe it is a good time to use StrOrPromise instead?
There was a problem hiding this comment.
Do you mean importing it from django_stubs_ext?
There was a problem hiding this comment.
Yes, this is non blocking. We can do this later.
There was a problem hiding this comment.
Perhaps we should do the whole file at once? To not introduce any ambiguity?
There was a problem hiding this comment.
Yes, I agree :)
Maybe even for the whole project.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The default set by Django is a translate:able string:
https://github.com/django/django/blob/617bcf611f3daa796e4054ba041089ece30a32fc/django/db/models/fields/related.py#L1342
Related issues
ManyToManyFieldis not complete #754