Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add Path type argument to tuple returned by get_app_template_dirs #2266

Merged

Conversation

joshuadavidthomas
Copy link
Contributor

@joshuadavidthomas joshuadavidthomas commented Jul 19, 2024

I have made things!

This is my first PR to this project, if there's anything else needed from me let me know.

Related issues

Copy link
Member

@sobolevn sobolevn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like it returns str, not Path:

template_dirs = [
        str(Path(app_config.path) / dirname) # ...

Copy link
Member

@sobolevn sobolevn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sobolevn sobolevn merged commit 9484698 into typeddjango:master Jul 20, 2024
36 checks passed
@joshuadavidthomas joshuadavidthomas deleted the get_app_template_dirs branch July 24, 2024 04:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

django.template.utils.get_app_template_dirs return tuple missing type argument
2 participants