Expand CheckRegistry.register as function (#2232) #2233
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Allow setting tags and "deploy" flag when using register as a function. Previously, only the decorator overload allowed these.
jwhitlock
force-pushed
the
jwhitlock-checks-register-2232
branch
from
b1f1450 to
1963a2a
Compare
sobolevn
reviewed
Jun 25, 2024
tests/typecheck/core/test_checks.yml
Outdated
| @@ -27,3 +27,45 @@ | |||
|
|
|||
| @register() # E: Value of type variable "_C" of function cannot be "Callable[[int], Sequence[CheckMessage]]" [type-var] | |||
| def wrong_args(bla: int) -> Sequence[CheckMessage]: ... | |||
| - case: test_checks_register_as_function | |||
There was a problem hiding this comment.
Thanks! But tests for this feature is not required :)
There was a problem hiding this comment.
Does that mean I should remove the new tests before this PR is accepted?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow setting tags and "deploy" flag when using register as a function. Previously, only the decorator overload allowed these. Closes #2232.