Lookup should be a subtype of Expression
#2199
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sobolevn
approved these changes
May 30, 2024
intgr
reviewed
May 31, 2024
|
|
||
| CheckConstraint( | ||
| name="less_than_constraint", | ||
| check=LessThan(F("months"), 1) |
There was a problem hiding this comment.
Since mypy typecheck tests are slow, and we also want to test with Pyright, such tests are better added under tests/assert_type
There was a problem hiding this comment.
Thanks, I should've waited for your review before merging.
I'll fix it in a follow-up.
There was a problem hiding this comment.
No problem, this is more of a minor quibble. Follow-up PR is welcome. :)
Welcome back to django-stubs development @mkurnikov! 🎉
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have made things!
Added test to trigger the type failure.
Had to change signature for
set_source_expressionstoCombinable | Expression, and remove some inherited methods.@sobolevn