Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add ManyToManyField.m2m_field_name and Model._get_pk_val methods #2177

Merged
merged 6 commits into from
May 28, 2024
Merged

Add ManyToManyField.m2m_field_name and Model._get_pk_val methods #2177

merged 6 commits into from
May 28, 2024

Conversation

YPCrumble
Copy link
Contributor

Thanks for maintaining this library! This PR adds a couple methods I use in my codebase that are part of models.Model and ManyToManyField. Let me know if any questions or concerns?

I have made things!

Related issues

Refs #204

@YPCrumble YPCrumble changed the title Feature/add get pk val Add two stubs related to models May 22, 2024
@YPCrumble
Copy link
Contributor Author

Thank you @Viicos - updated!

intgr
intgr reviewed May 23, 2024
View reviewed changes
Copy link
Collaborator

@intgr intgr left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Have a look at stubtest output too.

You can run it in a virtualenv locally with bash ./_local/stubtest.sh

django-stubs/db/models/base.pyi Outdated Show resolved Hide resolved
@intgr intgr self-assigned this May 23, 2024
@intgr intgr changed the title Add two stubs related to models Add ManyToManyField.m2m_field_name and Model._get_pk_val methods May 23, 2024
intgr
intgr approved these changes May 28, 2024
View reviewed changes
Copy link
Collaborator

@intgr intgr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I pushed fixes the allowlist as well to make CI pass (and move around related allowlist entries).

@intgr intgr merged commit cb73083 into typeddjango:master May 28, 2024
36 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Viicos Viicos Viicos left review comments

@intgr intgr intgr approved these changes

Assignees

@intgr intgr

Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@YPCrumble @intgr @Viicos