BaseBackend.get_user: Relax user_id param type
#2121
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In theory, this pk could be anything, given that `AUTH_USER_MODEL` can resolved to any custom model (often a `AbstractBaseUser` subclass.) See also: - https://docs.djangoproject.com/en/5.0/topics/auth/customizing/#substituting-a-custom-user-model - https://github.com/django/django/blob/5.0.4/django/contrib/auth/backends.py
sobolevn
approved these changes
May 3, 2024
intgr
reviewed
May 5, 2024
| @@ -13,7 +13,7 @@ UserModel: Any | |||
|
|
|||
| class BaseBackend: | |||
| def authenticate(self, request: HttpRequest | None, **kwargs: Any) -> AbstractBaseUser | None: ... | |||
| def get_user(self, user_id: int) -> AbstractBaseUser | None: ... | |||
| def get_user(self, user_id: Any) -> AbstractBaseUser | None: ... | |||
There was a problem hiding this comment.
Personally I would have preferred int | str | UUID. But OK, let's keep this for now
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Loosen the
user_idtyping inBaseBackend.get_user()In theory, this pk could be anything, given that
AUTH_USER_MODELcan resolved to any custom model (often aAbstractBaseUsersubclass.)See also:
Related issues
django.contrib.auth.BaseBackend.get_user():user_idis too strict #2120