Fix IndexError for custom queryset managers #1913
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sometimes Mypy crashes on this line with an IndexError. This change builds on the change in typeddjango#1786 by making further use of the safer variable `typed_var`. `typed_var` will equal `manager_instance.args` if `manager_instance.args` is populated, but if it isn't it will have another sensible value we can use instead. Because that value should be populated, this prevents the crash.
intgr
reviewed
Mar 20, 2024
intgr
approved these changes
Apr 30, 2024
|
Apologies for not getting back to you on the tests. I've had this on my todo list, but wasn't able to prioritise it. Thank you for merging this! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sometimes Mypy crashes on this line with an IndexError.
This change builds on the change in #1786 by making further use of the safer variable
typed_var.typed_varwill equalmanager_instance.argsifmanager_instance.argsis populated, but if it isn't it will have another sensible value we can use instead.Because that value should be populated, this prevents the crash.
Related issues
Original issue: #1785
Previous fix: #1786