Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move plugin generated <Model>_RelatedManager entries to allowlist #1806

Merged
merged 1 commit into from
Oct 30, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions scripts/stubtest/allowlist.txt
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,14 @@ django.core.files.storage.default_storage
# 'ManyRelatedManager' does exist and is declared locally, inside a function body
django.db.models.fields.related_descriptors.ManyRelatedManager

# '<Model>_RelatedManager' entries are plugin generated and these subclasses only exist
# _locally/dynamically_ runtime -- Created via
# 'django.db.models.fields.related_descriptors.create_reverse_many_to_one_manager'
django.contrib.admin.models.LogEntry_RelatedManager
django.contrib.auth.models.Group_RelatedManager
django.contrib.auth.models.Permission_RelatedManager
django.contrib.auth.models.User_RelatedManager

# BaseArchive abstract methods that take no argument, but typed with arguments to match the Archive and TarArchive Implementations
django.utils.archive.BaseArchive.list
django.utils.archive.BaseArchive.extract
Expand Down
4 changes: 0 additions & 4 deletions scripts/stubtest/allowlist_todo.txt
Original file line number Diff line number Diff line change
Expand Up @@ -63,7 +63,6 @@ django.contrib.admin.models.LogEntry.object_repr
django.contrib.admin.models.LogEntry.user
django.contrib.admin.models.LogEntry.user_id
django.contrib.admin.models.LogEntryManager.__slotnames__
django.contrib.admin.models.LogEntry_RelatedManager
django.contrib.admin.options.BaseModelAdmin
django.contrib.admin.options.BaseModelAdmin.form
django.contrib.admin.options.BaseModelAdmin.media
Expand Down Expand Up @@ -168,7 +167,6 @@ django.contrib.auth.models.Group.name
django.contrib.auth.models.Group.permissions
django.contrib.auth.models.Group.user_set
django.contrib.auth.models.GroupManager.__slotnames__
django.contrib.auth.models.Group_RelatedManager
django.contrib.auth.models.Permission.codename
django.contrib.auth.models.Permission.content_type
django.contrib.auth.models.Permission.content_type_id
Expand All @@ -177,7 +175,6 @@ django.contrib.auth.models.Permission.id
django.contrib.auth.models.Permission.name
django.contrib.auth.models.Permission.user_set
django.contrib.auth.models.PermissionManager.__slotnames__
django.contrib.auth.models.Permission_RelatedManager
django.contrib.auth.models.PermissionsMixin.Meta.abstract
django.contrib.auth.models.PermissionsMixin.groups
django.contrib.auth.models.PermissionsMixin.is_superuser
Expand All @@ -199,7 +196,6 @@ django.contrib.auth.models.User.password
django.contrib.auth.models.User.user_permissions
django.contrib.auth.models.User.username
django.contrib.auth.models.UserManager.__slotnames__
django.contrib.auth.models.User_RelatedManager
django.contrib.auth.password_validation.CommonPasswordValidator.DEFAULT_PASSWORD_LIST_PATH
django.contrib.auth.password_validation.CommonPasswordValidator.__init__
django.contrib.auth.password_validation.PasswordValidator
Expand Down