Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added search_help_text= parameter to ChangeList.__init__() #1801

Merged
merged 1 commit into from
Oct 26, 2023
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Fix admin ChangeList.__init__
The new parameter search_help_text was added with Django 4:
django/django@1143f3b
quinox committed Oct 26, 2023
commit cac63bd923c310b9612fccef20f870d4f997b386
2 changes: 2 additions & 0 deletions django-stubs/contrib/admin/views/main.pyi
Original file line number Diff line number Diff line change
@@ -27,6 +27,7 @@ class ChangeList:
list_filter: Sequence[_ListFilterT]
date_hierarchy: Any
search_fields: Sequence[str]
search_help_text: str | None
list_select_related: bool | Sequence[str]
list_per_page: int
list_max_show_all: int
@@ -59,6 +60,7 @@ class ChangeList:
list_editable: Sequence[str],
model_admin: ModelAdmin,
sortable_by: Sequence[str] | None,
search_help_text: str | None,
) -> None: ...
def get_filters_params(self, params: dict[str, Any] | None = ...) -> dict[str, Any]: ...
def get_filters(self, request: HttpRequest) -> tuple[list[ListFilter], bool, dict[str, bool | str], bool, bool]: ...
1 change: 0 additions & 1 deletion scripts/stubtest/allowlist_todo.txt
Original file line number Diff line number Diff line change
@@ -90,7 +90,6 @@ django.contrib.admin.utils.prepare_lookup_value
django.contrib.admin.views.autocomplete.AutocompleteJsonView.admin_site
django.contrib.admin.views.autocomplete.AutocompleteJsonView.process_request
django.contrib.admin.views.autocomplete.AutocompleteJsonView.serialize_result
django.contrib.admin.views.main.ChangeList.__init__
django.contrib.admin.views.main.ChangeList.search_form_class
django.contrib.admin.views.main.ChangeListSearchForm
django.contrib.admin.widgets.AutocompleteMixin.media