Add SessionBase methods, change SessionStore.get_model_class() return

[realsuayip]

https://github.com/django/django/blob/main/django/contrib/sessions/backends/base.py
https://github.com/django/django/blob/main/django/contrib/sessions/backends/db.py

[sobolevn]

we usually don't type protected methods, why do you need this?

[realsuayip]

_get_or_create_session_key may needed to be used when overriding SessionStore. For example:

https://github.com/QueraTeam/django-qsessions/blob/ecfd7327ebe32483746704b59fca72f05be07284/qsessions/backends/db.py#LL43C14-L43C14

I don't have any use cases for the others, typed them just in case. I could remove those.

[sobolevn]

Please, remove them :)
We can always bring them back if there are real use-cases.

[intgr]

I've pushed a change to remove the underscore methods.

[intgr]

Why remove these 3 methods? Looks like they're present still: https://github.com/django/django/blob/main/django/contrib/sessions/backends/base.py#L121C1-L129

[intgr]

I've added them back for now, so I can merge this for the 4.2.1 release.

If there was a good reason to remove them, please let me know.

[realsuayip]

In stubs, SessionBase is defined as subclass of dict:

django-stubs/django-stubs/contrib/sessions/backends/base.pyi

Line 9 in 21e541f

class SessionBase(dict[str, Any]):

not in Django though:

https://github.com/django/django/blob/27fed08e5ff597c813de25b6e89dc300a1f4231b/django/contrib/sessions/backends/base.py#LL33C9-L33C9

Subclassing from dict should cover for keys, values and items (and with proper return values, not just Any)

I'm guessing the subclassing is probably done so as not type all the dict related dunder methods, which are present in Django to ensure dict-like behavior.