Fix aiterator #1449
Merged
Fix aiterator #1449
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
intgr
approved these changes
Apr 20, 2023
| @@ -37,7 +37,7 @@ class BaseManager(Generic[_T]): | |||
| # NOTE: The following methods are in common with QuerySet, but note that the use of QuerySet as a return type | |||
| # rather than a self-type (_QS), since Manager's QuerySet-like methods return QuerySets and not Managers. | |||
| def iterator(self, chunk_size: int = ...) -> Iterator[_T]: ... | |||
| async def aiterator(self, chunk_size: int = ...) -> Iterator[_T]: ... | |||
| def aiterator(self, chunk_size: int = ...) -> AsyncIterator[_T]: ... | |||
There was a problem hiding this comment.
Weird that the async keyword has to be removed as well. But according to this SO post https://stackoverflow.com/a/68911014/177663 that is correct.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changeset fixes the following:
aiteratordoes not exist onRawQuerySetin Django, so the corresponding typedef is getting removed hereaiteratortypedef was missing on_QuerySeteven though it is supported by Djangoaiteratortypedef was incorrectly typed onBaseManager