Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add generic BaseConnectionHandler #1349

Merged
merged 2 commits into from
Feb 3, 2023
Merged

Add generic BaseConnectionHandler #1349

merged 2 commits into from
Feb 3, 2023

Conversation

adambirds
Copy link
Contributor

I have made things!

Had an issue with BaseConnectionHandler not accepting a generic even though mypy said it needed one. Patching it fixed my issues locally.

Related issues

ngnpope
ngnpope approved these changes Jan 31, 2023
View reviewed changes
Copy link
Contributor

@ngnpope ngnpope left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@intgr intgr changed the title Add generic BaseConnectionHandler. Add generic BaseConnectionHandler Feb 3, 2023
@intgr intgr merged commit b4f1c3c into typeddjango:master Feb 3, 2023
@intgr
Copy link
Collaborator

intgr commented Feb 3, 2023

Thanks!

@adambirds adambirds deleted the generic-baseconnectionhandler branch February 3, 2023 11:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ngnpope ngnpope ngnpope approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@adambirds @intgr @ngnpope