Fix crash when filtering on implicit pk field on abstract model
#1328
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
flaeppe
changed the title
pk field on abstract model
intgr
reviewed
Jan 23, 2023
intgr
changed the title
pk field on abstract modelpk field on abstract model
intgr
approved these changes
Jan 23, 2023
|
Actually, #1189 wasn't closed by this. My example was faulty, it was a |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have made things!
Avoid crashing when queryset filters on an implicit
pkfield for a model, when model is abstract.I tried to figure out #1261 and while type checking Django's test suite I came across the same error as in #1189. But reproduced when filtering on
django.contrib.auth.models.AbstractUser.Related issues
Closes #1189
I wasn't able to reproduce with the example found in the linked issue though.