[5.0.3 regression] GenericRelation has no attribute

[andersk]

In 5.0.3, the value of a GenericRelation field is given the useless type _ST (an unbound type variable), and trying to do anything with it gives errors like error: "_ST" has no attribute "all" [attr-defined].

This was introduced with b2b1afa (#2261, cc @rafonseca).

django-stubs/django-stubs/contrib/contenttypes/fields.pyi

Line 69 in d60e31e

class GenericRelation(ForeignObject):

ForeignObject is generic and requires generic arguments. Without these generic arguments, it was previously interpreted as ForeignObject[Any, Any] but now it’s interpreted as the invalid ForeignObject[Any, _ST].

django-stubs/django-stubs/db/models/fields/related.pyi

Lines 29 to 34 in d60e31e

	# __set__ value type
	_ST = TypeVar("_ST")
	# __get__ return type
	_GT = TypeVar("_GT", default=_ST)
	class RelatedField(FieldCacheMixin, Field[_ST, _GT]):

Complete test case

pyproject.toml

[tool.django-stubs]
django_settings_module = "my_settings"

[tool.mypy]
plugins = ["mypy_django_plugin.main"]

my_settings.py

INSTALLED_APPS = ["django.contrib.contenttypes", "my_app"]

my_app/__init__.py

# empty

my_app/models.py

from django.contrib.contenttypes.fields import GenericForeignKey, GenericRelation
from django.contrib.contenttypes.models import ContentType
from django.db import models

class TaggedItem(models.Model):
    tag = models.SlugField()
    content_type = models.ForeignKey(ContentType, on_delete=models.CASCADE)
    object_id = models.PositiveIntegerField()
    content_object = GenericForeignKey("content_type", "object_id")

class Bookmark(models.Model):
    url = models.URLField()
    tags = GenericRelation(TaggedItem)

def test(b: Bookmark) -> None:
    b.tags.all()  # error: "_ST" has no attribute "all"  [attr-defined]

$ mypy .
my_app/models.py:16: error: "_ST" has no attribute "all"  [attr-defined]
Found 1 error in 1 file (checked 3 source files)

[sobolevn]

This is a simple workaround: #2300
PR with a proper generic type is welcome!

[rafonseca]

Hi @andersk ,
Sorry for that, I'm using pyright. This should get solved when mypy implements PEP696