-
Notifications
You must be signed in to change notification settings - Fork 341
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Assemble and deploy a single apt package #6935
Merged
flyingsilverfin
merged 7 commits into
typedb:development
from
dmitrii-ubskii:apt-package
Nov 6, 2023
Merged
Assemble and deploy a single apt package #6935
flyingsilverfin
merged 7 commits into
typedb:development
from
dmitrii-ubskii:apt-package
Nov 6, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PR Review ChecklistDo not edit the content of this comment. The PR reviewer should simply update this comment by ticking each review item below, as they get completed. Trivial Change
Code
Architecture
|
This was referenced Nov 6, 2023
flyingsilverfin
pushed a commit
to typedb/typedb-common
that referenced
this pull request
Nov 6, 2023
## What is the goal of this PR? We no longer deploy `typedb-binary` as a separate package, but rather a single package called `typedb` which contains server, console, and the binary. See typedb/typedb#6935.
flyingsilverfin
approved these changes
Nov 6, 2023
flyingsilverfin
changed the title
Single apt package
Assemble and deploy a single apt package
Nov 6, 2023
dmitrii-ubskii
force-pushed
the
apt-package
branch
from
November 6, 2023 15:37
4970db1
to
2b5d9b9
Compare
This reverts commit 3d373db.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the goal of this PR?
We no longer deploy
typedb-server
ortypedb-all
as a separate package, but rather a single package calledtypedb
which contains server, console, and the binary. This approach now mirrors the 'brew' installation package.