Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Assemble and deploy a single apt package #6935

Merged
merged 7 commits into from
Nov 6, 2023

Conversation

dmitrii-ubskii
Copy link
Member

@dmitrii-ubskii dmitrii-ubskii commented Nov 6, 2023

What is the goal of this PR?

We no longer deploy typedb-server or typedb-all as a separate package, but rather a single package called typedb which contains server, console, and the binary. This approach now mirrors the 'brew' installation package.

@typedb-bot
Copy link
Member

typedb-bot commented Nov 6, 2023

PR Review Checklist

Do not edit the content of this comment. The PR reviewer should simply update this comment by ticking each review item below, as they get completed.


Trivial Change

  • This change is trivial and does not require a code or architecture review.

Code

  • Packages, classes, and methods have a single domain of responsibility.
  • Packages, classes, and methods are grouped into cohesive and consistent domain model.
  • The code is canonical and the minimum required to achieve the goal.
  • Modules, libraries, and APIs are easy to use, robust (foolproof and not errorprone), and tested.
  • Logic and naming has clear narrative that communicates the accurate intent and responsibility of each module (e.g. method, class, etc.).
  • The code is algorithmically efficient and scalable for the whole application.

Architecture

  • Any required refactoring is completed, and the architecture does not introduce technical debt incidentally.
  • Any required build and release automations are updated and/or implemented.
  • Any new components follows a consistent style with respect to the pre-existing codebase.
  • The architecture intuitively reflects the application domain, and is easy to understand.
  • The architecture has a well-defined hierarchy of encapsulated components.
  • The architecture is extensible and scalable.

@dmitrii-ubskii dmitrii-ubskii changed the title Apt package Single apt package Nov 6, 2023
@dmitrii-ubskii dmitrii-ubskii added this to the 2.25.0 milestone Nov 6, 2023
@dmitrii-ubskii dmitrii-ubskii marked this pull request as ready for review November 6, 2023 12:11
flyingsilverfin pushed a commit to typedb/typedb-common that referenced this pull request Nov 6, 2023
## What is the goal of this PR?

We no longer deploy `typedb-binary` as a separate package, but rather a
single package called `typedb` which contains server, console, and the
binary. See typedb/typedb#6935.
@flyingsilverfin flyingsilverfin changed the title Single apt package Assemble and deploy a single apt package Nov 6, 2023
@flyingsilverfin flyingsilverfin merged commit 3f64a89 into typedb:development Nov 6, 2023
@dmitrii-ubskii dmitrii-ubskii deleted the apt-package branch December 11, 2023 16:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants