-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix invalid automation.yml
and update dependencies
#171
Conversation
PR Review ChecklistDo not edit the content of this comment. The PR reviewer should simply update this comment by ticking each review item below, as they get completed. Code
Architecture
|
@@ -143,4 +143,4 @@ release: | |||
command: | | |||
export DEPLOY_CRATE_TOKEN=$REPO_CRATES_TOKEN | |||
bazel run --define version=$(cat VERSION) //grpc/rust:deploy_crate -- release | |||
dependencies: [build, build-dependency] | |||
dependencies: [deploy-github] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[deploy-github]
is the correct dependency list. This was not previously caught in CI because of:
remote = "https://github.com/alexjpwalker/dependencies", | ||
commit = "1bf0ec950a59ad170c826f9fe163701c2e0b2233", # sync-marker: do not remove this comment, this is used for sync-dependencies by @vaticle_dependencies | ||
remote = "https://github.com/vaticle/dependencies", | ||
commit = "49de5861769ebb4b4b87438324e8a5922bf75dbe", # sync-marker: do not remove this comment, this is used for sync-dependencies by @vaticle_dependencies |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What is the goal of this PR?
We fixed a semantic error in
automation.yml
and updateddependencies
.What are the changes implemented in this PR?
deploy-crate-snapshot
in automation filedependencies
tovaticle
(previously a fork)