Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix invalid automation.yml and update dependencies #171

Merged
merged 1 commit into from
Nov 22, 2022

Conversation

alexjpwalker
Copy link
Member

What is the goal of this PR?

We fixed a semantic error in automation.yml and updated dependencies.

What are the changes implemented in this PR?

  • Update prerequisites of deploy-crate-snapshot in automation file
  • Update dependencies to vaticle (previously a fork)

@typedb-bot
Copy link
Member

typedb-bot commented Nov 22, 2022

PR Review Checklist

Do not edit the content of this comment. The PR reviewer should simply update this comment by ticking each review item below, as they get completed.


Code

  • Packages, classes, and methods have a single domain of responsibility.
  • Packages, classes, and methods are grouped into cohesive and consistent domain model.
  • The code is canonical and the minimum required to achieve the goal.
  • Modules, libraries, and APIs are easy to use, robust (foolproof and not errorprone), and tested.
  • Logic and naming has clear narrative that communicates the accurate intent and responsibility of each module (e.g. method, class, etc.).
  • The code is algorithmically efficient and scalable for the whole application.

Architecture

  • Any required refactoring is completed, and the architecture does not introduce technical debt incidentally.
  • Any required build and release automations are updated and/or implemented.
  • Any new components follows a consistent style with respect to the pre-existing codebase.
  • The architecture intuitively reflects the application domain, and is easy to understand.
  • The architecture has a well-defined hierarchy of encapsulated components.
  • The architecture is extensible and scalable.

@@ -143,4 +143,4 @@ release:
command: |
export DEPLOY_CRATE_TOKEN=$REPO_CRATES_TOKEN
bazel run --define version=$(cat VERSION) //grpc/rust:deploy_crate -- release
dependencies: [build, build-dependency]
dependencies: [deploy-github]
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[deploy-github] is the correct dependency list. This was not previously caught in CI because of:

remote = "https://github.com/alexjpwalker/dependencies",
commit = "1bf0ec950a59ad170c826f9fe163701c2e0b2233", # sync-marker: do not remove this comment, this is used for sync-dependencies by @vaticle_dependencies
remote = "https://github.com/vaticle/dependencies",
commit = "49de5861769ebb4b4b87438324e8a5922bf75dbe", # sync-marker: do not remove this comment, this is used for sync-dependencies by @vaticle_dependencies
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@haikalpribadi haikalpribadi merged commit 3f3958a into typedb:master Nov 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants