Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Python. Fix driver.close(). Add integration tests for connection closing for both core and cloud #670

Merged
merged 1 commit into from
Jul 5, 2024

Conversation

farost
Copy link
Member

@farost farost commented Jul 5, 2024

Usage and product changes

We fix the issue #669, where the Python Driver didn't close the connection when calling TypeDBDriver.close().

Implementation

We needed to reverse the condition of is_open().

The main issue is the absence of tests for our drivers' connections, so we:

@farost farost requested a review from dmitrii-ubskii July 5, 2024 09:53
@typedb-bot
Copy link
Member

typedb-bot commented Jul 5, 2024

PR Review Checklist

Do not edit the content of this comment. The PR reviewer should simply update this comment by ticking each review item below, as they get completed.


Trivial Change

  • This change is trivial and does not require a code or architecture review.

Code

  • Packages, classes, and methods have a single domain of responsibility.
  • Packages, classes, and methods are grouped into cohesive and consistent domain model.
  • The code is canonical and the minimum required to achieve the goal.
  • Modules, libraries, and APIs are easy to use, robust (foolproof and not errorprone), and tested.
  • Logic and naming has clear narrative that communicates the accurate intent and responsibility of each module (e.g. method, class, etc.).
  • The code is algorithmically efficient and scalable for the whole application.

Architecture

  • Any required refactoring is completed, and the architecture does not introduce technical debt incidentally.
  • Any required build and release automations are updated and/or implemented.
  • Any new components follows a consistent style with respect to the pre-existing codebase.
  • The architecture intuitively reflects the application domain, and is easy to understand.
  • The architecture has a well-defined hierarchy of encapsulated components.
  • The architecture is extensible and scalable.

Copy link
Member

@dmitrii-ubskii dmitrii-ubskii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@farost farost merged commit fd8d04e into typedb:development Jul 5, 2024
22 checks passed
@farost farost deleted the python-driver-close-connection branch October 4, 2024 11:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants