-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DRAFT: Add Node 16, PNPM and Chrome to Vaticle Ubuntu Docker image; add tower-http
crate lib
#431
Draft
alexjpwalker
wants to merge
8
commits into
typedb:development
Choose a base branch
from
alexjpwalker:ubuntu-docker-pnpm
base: development
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PR Review ChecklistDo not edit the content of this comment. The PR reviewer should simply update this comment by ticking each review item below, as they get completed. Trivial Change
Code
Architecture
|
alexjpwalker
changed the title
Add Node 16 and PNPM to Vaticle Ubuntu Docker image; add
Add Node 16, PNPM and Chrome to Vaticle Ubuntu Docker image; add Apr 4, 2023
tower-http
crate libtower-http
crate lib
alexjpwalker
changed the title
Add Node 16, PNPM and Chrome to Vaticle Ubuntu Docker image; add
DRAFT: Add Node 16, PNPM and Chrome to Vaticle Ubuntu Docker image; add Apr 14, 2023
tower-http
crate libtower-http
crate lib
Reverting to draft as we now want to create a new image |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the goal of this PR?
We added Node 16, PNPM and Chrome to the Vaticle Ubuntu Docker image, and added the crate library
tower-http
with thecors
feature enabled.What are the changes implemented in this PR?
The new TypeDB Web server will be running Scully in the background through Node.js, using Puppeteer (which requires Google Chrome). These take quite a while (a few minutes) to install and we don't want to repeat that process on each fresh build of the website.
It also uses CORS for local development so we need the
tower-http
crate dependency declared.