Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DRAFT: Add Node 16, PNPM and Chrome to Vaticle Ubuntu Docker image; add tower-http crate lib #431

Draft
wants to merge 8 commits into
base: development
Choose a base branch
from

Conversation

alexjpwalker
Copy link
Member

@alexjpwalker alexjpwalker commented Mar 31, 2023

What is the goal of this PR?

We added Node 16, PNPM and Chrome to the Vaticle Ubuntu Docker image, and added the crate library tower-http with the cors feature enabled.

What are the changes implemented in this PR?

The new TypeDB Web server will be running Scully in the background through Node.js, using Puppeteer (which requires Google Chrome). These take quite a while (a few minutes) to install and we don't want to repeat that process on each fresh build of the website.

It also uses CORS for local development so we need the tower-http crate dependency declared.

@alexjpwalker alexjpwalker self-assigned this Mar 31, 2023
@typedb-bot
Copy link
Member

typedb-bot commented Mar 31, 2023

PR Review Checklist

Do not edit the content of this comment. The PR reviewer should simply update this comment by ticking each review item below, as they get completed.


Trivial Change

  • This change is trivial and does not require a code or architecture review.

Code

  • Packages, classes, and methods have a single domain of responsibility.
  • Packages, classes, and methods are grouped into cohesive and consistent domain model.
  • The code is canonical and the minimum required to achieve the goal.
  • Modules, libraries, and APIs are easy to use, robust (foolproof and not errorprone), and tested.
  • Logic and naming has clear narrative that communicates the accurate intent and responsibility of each module (e.g. method, class, etc.).
  • The code is algorithmically efficient and scalable for the whole application.

Architecture

  • Any required refactoring is completed, and the architecture does not introduce technical debt incidentally.
  • Any required build and release automations are updated and/or implemented.
  • Any new components follows a consistent style with respect to the pre-existing codebase.
  • The architecture intuitively reflects the application domain, and is easy to understand.
  • The architecture has a well-defined hierarchy of encapsulated components.
  • The architecture is extensible and scalable.

@alexjpwalker alexjpwalker changed the title Add Node 16 and PNPM to Vaticle Ubuntu Docker image; add tower-http crate lib Add Node 16, PNPM and Chrome to Vaticle Ubuntu Docker image; add tower-http crate lib Apr 4, 2023
@alexjpwalker alexjpwalker requested a review from lolski April 13, 2023 15:31
@alexjpwalker alexjpwalker marked this pull request as draft April 14, 2023 16:50
@alexjpwalker alexjpwalker changed the title Add Node 16, PNPM and Chrome to Vaticle Ubuntu Docker image; add tower-http crate lib DRAFT: Add Node 16, PNPM and Chrome to Vaticle Ubuntu Docker image; add tower-http crate lib Apr 14, 2023
@alexjpwalker
Copy link
Member Author

Reverting to draft as we now want to create a new image vaticle/web instead

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants