Skip to content

Add a few docs about vscode extension monkeypatches #822

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
machty merged 2 commits into from
Mar 19, 2025
Merged

Add a few docs about vscode extension monkeypatches #822

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
dfd42b0
Add a few docs to monkeypatches
machty Mar 19, 2025
15a59f9
prettier
machty Mar 19, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 12 additions & 3 deletions packages/vscode/src/extension.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -154,8 +154,6 @@ export const { activate, deactivate } = defineExtension(async () => {
},
);

// workspaceFolders.value.forEach((workspaceFolder) =>

return volarLabs.extensionExports;
});

Expand Down Expand Up @@ -242,7 +240,16 @@ try {
// @ts-expect-error – not easy to type
let text = readFileSync(...args) as string;

// patch readPlugins
// patch readPlugins so that it initializes our plugin with the language IDs specified
// in the VSCode config (e.g. `glint.server.includeLanguages`), rather than the language IDs
// specified in the Glint VSCode extension package.json `typescriptServerPlugins` payload.
//
// TODO: do we actually need this configure-ability or would it suffice to just use
// a hardcoded array of ['glimmer-js', 'glimmer-ts', 'handlebars']? If so, need to update
// the Glint VSCode extension package.json `typescriptServerPlugins` payload to include
// handlebars.
//
// https://github.com/microsoft/vscode/blob/6900113cf934d3d379757534d6f57929c5eb87f2/extensions/typescript-language-features/src/tsServer/plugins.ts#L81
text = text.replace(
'languages:Array.isArray(e.languages)',
[
Expand Down Expand Up @@ -270,6 +277,8 @@ try {

/**
* VSCode >= 1.87.0
*
* https://github.com/microsoft/vscode/blob/7e4e3c373200b0b1564da09d1af0279a0cde8caf/extensions/typescript-language-features/src/configuration/languageIds.ts#L14-L19
*/

text = text.replace(
Expand Down
Loading