Skip to content

feat: drop support for classic component layout #721

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
machty merged 2 commits into from
Jul 9, 2024
Merged

feat: drop support for classic component layout #721

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
80d654c
feat: drop support for classic component layout
aklkv May 18, 2024
20b7c93
Delete component with classicly resolved template
NullVoxPopuli Jun 20, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 0 additions & 3 deletions packages/environment-ember-loose/-private/environment/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,9 +62,6 @@ export default function emberLooseEnvironment(
templatePath.replace(REGEXES.POD_TEMPLATE, '/controller.ts'),
templatePath.replace(REGEXES.POD_TEMPLATE, '/route.ts')
);
} else if (templatePath.includes('/templates/components/')) {
// Classic component
candidates.push(colocatedTsScriptPath.replace('/templates/components/', '/components/'));
} else if (templatePath.includes('/templates/')) {
// Classic controller/route
candidates.push(
Expand Down
8 changes: 0 additions & 8 deletions packages/environment-ember-loose/__tests__/environment.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,14 +69,6 @@ describe('Environments: Ember Loose', () => {
'/route.js',
]);

// Classic component
Copy link
Copy Markdown
Contributor Author

@aklkv aklkv May 18, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we keep a parts of this test or drop it all together 🤔

Copy link
Copy Markdown
Contributor

@NullVoxPopuli NullVoxPopuli May 18, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should drop everything related

expect(env?.getPossibleScriptPaths('/templates/components/hello.hbs')).toEqual([
'/templates/components/hello.ts',
'/templates/components/hello.js',
'/components/hello.ts',
'/components/hello.js',
]);

// Classic controller/route
expect(env?.getPossibleScriptPaths('/templates/hello.hbs')).toEqual([
'/templates/hello.ts',
Expand Down
2 changes: 0 additions & 2 deletions test-packages/ts-ember-app/app/components/foo.hbs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,8 +20,6 @@

<Baz />

<Qux />

<this.MaybeComponent @arg="hi" />

{{! @glint-expect-error: missing required arg }}
Expand Down
12 changes: 0 additions & 12 deletions test-packages/ts-ember-app/app/components/qux.ts
View file
Open in desktop

This file was deleted.

4 changes: 0 additions & 4 deletions test-packages/ts-ember-app/app/templates/components/qux.hbs
View file
Open in desktop

This file was deleted.

13 changes: 0 additions & 13 deletions test-packages/ts-ember-app/tests/integration/components/qux-test.ts
View file
Open in desktop

This file was deleted.

2 changes: 0 additions & 2 deletions test-packages/ts-ember-preview-types/app/components/foo.hbs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,8 +20,6 @@

<Baz />

<Qux />

<this.MaybeComponent @arg="hi" />

{{! @glint-expect-error: missing required arg }}
Expand Down
11 changes: 0 additions & 11 deletions test-packages/ts-ember-preview-types/app/components/qux.ts
View file
Open in desktop

This file was deleted.

4 changes: 0 additions & 4 deletions test-packages/ts-ember-preview-types/app/templates/components/qux.hbs
View file
Open in desktop

This file was deleted.