-
Notifications
You must be signed in to change notification settings - Fork 51
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Switch to pnpm #670
base: main
Are you sure you want to change the base?
Switch to pnpm #670
Conversation
af9f714
to
aa69d6b
Compare
fb2cccc
to
78fdb8b
Compare
@@ -1,9 +1,8 @@ | |||
import { SafeString } from '@glimmer/runtime'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we can't import from Glimmer, because Glimmer is ESM, and Glint is not.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Alternatively, the tests could be extracted to an ESM package, but then we'd lose the ability to test private things.
A solution could be vitest's in-source testing.
This would require revamping how all the glint packages are built though. (not using tsc)
…inimal to get around the leakyness provided by yarn
yarn@v1
can't be trusted. this has been known for ages.Also, newer tooling isn't supporting
yarn@v1
.unblocks: #668
Changes:
(a requirement to get types passing)
Previously, everything was all loosey goosey / incorrect.
@glimmer/runtime
was not specified, adding it adds the ESM version of Glimmer. No modern version of@glimmer/*
exports CJS, and thus is not compatible with Glint (which is compiled to CJS (because VSCode extensions don't support ESM))@glint/core
was added to any package that invokes theglint
bin. This is required, becausebin
directories are are local to each package.devDependencies
@glint/core
cannot have tests that consume any environment package, because the environment packages depend on@glint/core