Default to TS's fixedPollingInterval watcher in tests
#651
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dfreeman
added
testing
dfreeman
force-pushed
the
fs-watching-in-ci
branch
from
ff3862e
to
81a435a
Compare
The filesystem watcher (which they changed to by default in TS 4.9) is just too unstable in the GH Actions runner for us to count on.
dfreeman
force-pushed
the
fs-watching-in-ci
branch
from
81a435a
to
1466eb1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In TS <= 4.8,
fixedPollingIntervalis the default watcher configuration. Starting in TS 4.9, they changed the default touseFsEvents. This is generally a good thing! It means that users get more efficient, more effective FS watching.For us, though, in the Actions runner, this causes instability in our tests. Some days it's totally fine, but others it can cause any of our tests that rely on FS events triggering behavior in
glint --watch(orglint --build --watch) to fail at random.This PR sets up any test projects generated with the
glint-monorepo-test-utilsProjectclass to continue using thefixedPollingIntervalstrategy. There shouldn't be any reason end users need to switch; this is just about FS watcher stability in the Actions runners.EDIT: Still a bit to do here