Fix broken links on "Getting Started" page #564
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Removes link to docs page for `glint-language-server` that was removed in typed-ember#416 - Fixes broken link to "Configuration"
HeroicEric
changed the title
glint-language-server docs page
|
Thank you! Internal link rot in these docs has definitely been a struggle—I try and do a pass any time something moves or changes, but inevitably we wind up with stragglers.
I honestly have no clue what's going on there 🤔 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes two broken links on "Getting Started" page.
glint-language-serverthat was removed inRemove unhelpful
glint-language-serverdocs page #416Side Note
There are a few other broken links throughout the docs but I don't understand how/why they're broken and they seem to magically sometimes not be broken in different preview versions.
For example, in the current live version of the "Getting Started" page the link to "Ember.js Installation" does not work. The path looks correct to me and the link works properly on GitHub when previewing the markdown files.
If you view the preview "revision" linked by GitBook in the checks for this PR this link is magically fixed. I'm not sure if that means that it will actually be fixed after merging this though.
Another example is the link to "Authoring Guide" on the "Using Addons" page. This link is broken in the live version AND the preview revision for this branch but seems to fix itself if ANY changes are made to the markdown file for page.