Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow each-in to accept key as a named arg #558

Merged
merged 3 commits into from
Apr 25, 2023
Merged

Allow each-in to accept key as a named arg #558

merged 3 commits into from
Apr 25, 2023

Conversation

LanceStasinski
Copy link
Contributor

fixes #541

@dfreeman
Copy link
Member

Thanks @LanceStasinski! The change itself looks good, just a couple of complaints from Prettier to knock out and then we can get this merged

@LanceStasinski LanceStasinski marked this pull request as ready for review April 24, 2023 12:12
@dfreeman dfreeman added the enhancement New feature or request label Apr 24, 2023
@dfreeman dfreeman merged commit 19fc141 into typed-ember:main Apr 25, 2023
@dfreeman
Copy link
Member

Thank you!

@LanceStasinski
Copy link
Contributor Author

Thank you!

@dfreeman, you're welcome!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support key option in each-in helper
2 participants
@LanceStasinski @dfreeman