Solve 'The Mystery of the Missing app.js 🕵️♂️' #89
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also fix things when linking
Member
|
OH MY GOSH. Hero. |
Contributor
|
Thanks for figuring this out! So we are importing relative to the project root instead of (also FYI you can add |
Member
Author
This has to be about the fourth time I've learned that trick, but I always forget about it again by the next time I need it 🤦♂️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Incremental compilation was broken because
app.jswas being transformed into a file just calledjs.This should also fix things when using a linked copy e-c-ts. The
serve-tsdiff is nasty, but all I did was wrap the module in a function so it could useproject.require()to ensure the CLI imports always resolve to the host app's copy.