Skip to content

Solve TS problems in kibana-vis-editors files #6

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tylersmalley merged 1 commit into from
Sep 1, 2021
Merged

Solve TS problems in kibana-vis-editors files #6

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/plugins/kibana_legacy/public/angular/angular_config.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -76,7 +76,7 @@ export const configureAppAngularModule = (
isLocalAngular: boolean,
getHistory?: () => History
) => {
const core = 'core' in newPlatform ? newPlatform.core : newPlatform;
const core = ('core' in newPlatform ? newPlatform.core : newPlatform) as CoreStart;
const packageInfo = newPlatform.env.packageInfo;

angularModule
Expand Down
2 changes: 2 additions & 0 deletions x-pack/plugins/lens/public/indexpattern_datasource/operations/definitions/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -346,6 +346,7 @@ interface FieldlessOperationDefinition<C extends BaseIndexPatternColumn> {
arg: BaseBuildColumnArgs & {
previousColumn?: IndexPatternColumn;
},
// @ts-ignore, TS not able to dig into this depth, https://github.com/elastic/kibana/issues/110761
columnParams?: (IndexPatternColumn & C)['params']
) => C;
/**
Expand Down Expand Up @@ -387,6 +388,7 @@ interface FieldBasedOperationDefinition<C extends BaseIndexPatternColumn> {
field: IndexPatternField;
previousColumn?: IndexPatternColumn;
},
// @ts-ignore, TS not able to dig into this depth, https://github.com/elastic/kibana/issues/110761
columnParams?: (IndexPatternColumn & C)['params'] & {
kql?: string;
lucene?: string;
Expand Down