Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Hard abort given invalid search command drilldown input #8

Closed
tylerdq opened this issue Aug 13, 2019 · 1 comment
Closed

Hard abort given invalid search command drilldown input #8

tylerdq opened this issue Aug 13, 2019 · 1 comment
Labels
bug Something isn't working

Comments

@tylerdq
Copy link
Owner

tylerdq commented Aug 13, 2019

Currently, if the user answers yes to the drilldown prompt after using the "search" command but provides a value that is not in the returned dataframe, the program will return a NameError: '<name> exception and exit in an ugly manner, preventing the user from trying again.

Perhaps write a function that checks if the input is in the dataframe and in case of an exception, returns an error message and asks for input again.
@tylerdq tylerdq added the bug Something isn't working label Aug 13, 2019
tylerdq added a commit that referenced this issue Aug 13, 2019
@tylerdq
Fix issue #8
c37d888 
- Added a new function loop to ask for a test the key
@tylerdq
Copy link
Owner Author

tylerdq commented Aug 13, 2019

Addressed in commit c37d888

@tylerdq tylerdq closed this as completed Aug 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@tylerdq