ApiKey additions #98
Merged
ApiKey additions #98
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rukai
force-pushed
the
version_api_improvements
branch
from
6990104 to
9a8d839
Compare
tychedelia
approved these changes
Dec 2, 2024
|
Oy, apologies, I think I may have merged these out of order and caused conflicts here. Messages needs to be regenerated. |
rukai
force-pushed
the
version_api_improvements
branch
from
cffaf4d to
4f063db
Compare
|
@rukai lmk when you think we should do a release. |
|
I'm thinking now is a good time, I don't have any other changes in mind atm |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces 2 new pieces of functionality around ApiKey
These were required to implement a unit test in my project that compares the currently supported versions of the project against the supported versions of the kafka-protocol crate.
The additions are:
ApiKey::iterate_all()function, it returns an iterator that iterates once over every ApiKey variantApiKey::valid_versions(&self)method, it returns the valid versions that can be used with this ApiKey variant.I'm happy to split the PR in two if one of these is easy to land and the other is not.