[Breaking change] remove "Key" suffix from ApiKey variants #97
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rukai
force-pushed
the
remove-"Key"-suffix-from-ApiKey-variants
branch
from
ce4b2c5 to
756a02b
Compare
rukai
force-pushed
the
remove-"Key"-suffix-from-ApiKey-variants
branch
from
756a02b to
ae5a3cb
Compare
|
@tychedelia This PR is very similar to the PR #61 which was merged without issue, so I'll consider this non-controversial and merge it tomorrow. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Similar change to #61
The "Key" suffix is redundant since the variants are usually written out as
ApiKey::ProduceKey.Additionally its common to log a key type by doing something like
log!("failed to parse message type {api_key:?}"), in this case including the Key is confusing because it seems likeKeyis part of the message name.