[Breaking change] Fix calling Records::encode
/ Records::decode
with None
#100
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Calling encode or decode with the correct compression automatically chosen is very difficult. Providing None results in an error like this:
For which the fix is to change the
None
toNone::<fn(&mut bytes::Bytes, Compression) -> Result<Bytes>>
.This is a pretty poor experience.
To fix this I am making
decode
/encode
provide the correct None value, and have the original implementation moved todecode_with_custom_compression
/encode_with_custom_compression
.@pdeva heads up that you will want to adjust your project to call
decode_with_custom_compression
instead ofdecode
.