feat(zksync acceptance test): extend test, add example .env for mainnet #18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| emergencyBrakeMultisig: process.env.L2_EMERGENCY_BRAKE_MULTISIG as string, | ||
| guardian: process.env.GUARDIAN_ADDRESS as string, | ||
| proxyAdmin: process.env.TRANSPARENT_PROXY_ADMIN as string, | ||
| diamondProxy: process.env.CONTRACTS_DIAMOND_PROXY_ADDR as string, |
There was a problem hiding this comment.
Technically, Diamond Proxy contract is the zkSync contract that is deployed to L1, so better to move this constant under l1 contants.
There was a problem hiding this comment.
I see you moved it in the env file, but I was referring to this e2e.ts
mpavlovic-txfusion
approved these changes
Nov 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
An extension of zkSync acceptance test to check more contract states (view functions).
Also added .env sample file with the mainnet proposed addresses https://research.lido.fi/t/wsteth-deployment-on-zksync/5701/4