Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Re-enable building with Go 1.16 #1491

Merged
merged 1 commit into from
Oct 3, 2021
Merged

feat: Re-enable building with Go 1.16 #1491

merged 1 commit into from
Oct 3, 2021

Conversation

twpayne
Copy link
Owner

@twpayne twpayne commented Oct 3, 2021

No description provided.

@twpayne
Copy link
Owner Author

twpayne commented Oct 3, 2021

Refs NixOS/nixpkgs#138102 and NixOS/nixpkgs#140399.

As the transition from Go 1.16 to Go 1.17 is more complicated than I realized (e.g darwin support on Nix, OpenBSD has Go 1.16.2), this PR re-adds support for building chezmoi on Go 1.16.

@twpayne twpayne marked this pull request as ready for review October 3, 2021 19:33
@twpayne
Copy link
Owner Author

twpayne commented Oct 3, 2021

cc @jhillyerd, I'll tag 2.6.1 now which should allow you to build chezmoi for NixOS without waiting for Go 1.17 in NixOS.

@twpayne twpayne merged commit 8d9a89b into master Oct 3, 2021
@twpayne twpayne deleted the go-1.16 branch October 3, 2021 19:34
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 29, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant