Skip to content

Conversation

@Hugos68
Copy link

@Hugos68 Hugos68 commented Oct 29, 2024

This PR attempts to create twoslash-svelte which is an extension of twoslashthat supports Svelte.

@netlify
Copy link

netlify bot commented Oct 29, 2024

Deploy Preview for twoslash ready!

Name Link
🔨 Latest commit b3e4639
🔍 Latest deploy log https://app.netlify.com/sites/twoslash/deploys/67e119f1d636fc000882f10f
😎 Deploy Preview https://deploy-preview-57--twoslash.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@Hugos68 Hugos68 marked this pull request as draft October 30, 2024 09:13
@Hugos68
Copy link
Author

Hugos68 commented Oct 31, 2024

@antfu @orta
A review would be appreiciated, I'm now at a point where I feel confident I have the code working. I was able to copy some code from twoslash-vue as it works similarly (convert source to tsx then typecheck and use sourcemaps to backtrack the original location).

All that's left is tests.

@Hugos68 Hugos68 marked this pull request as ready for review October 31, 2024 09:35
@orta
Copy link
Member

orta commented Oct 31, 2024

From a high level, this looks very cool to me!

@Hugos68
Copy link
Author

Hugos68 commented Nov 30, 2024

@antfu This is ready for review btw, not sure if you have missed it as I know you're inbox is quite lengthy.

@Hugos68
Copy link
Author

Hugos68 commented Dec 19, 2024

@dominikg, I might need some help as you're one of the maintainers of svelte2tsx correct?
When compiling the tsx coming from svelte2tsx how can I include the .d.ts files? I've tried many methods but can't find a consistent way where the user can install svelte2tsx and the twoslash-svelte package can use those files.

@Hugos68 Hugos68 marked this pull request as draft January 20, 2025 10:44
@dominikg
Copy link

dominikg commented Feb 2, 2025

@dominikg, I might need some help as you're one of the maintainers of svelte2tsx correct?

sorry for not responding sooner. I do not maintain svelte2tsx, @dummdidumm would be the best person to reach out to, you can try #editor-tools-questions on https://svelte.dev/chat

@Hugos68
Copy link
Author

Hugos68 commented Feb 2, 2025

No problem, and thanks, will do!

@Hugos68 Hugos68 marked this pull request as ready for review March 24, 2025 09:00
@Hugos68
Copy link
Author

Hugos68 commented Mar 24, 2025

@antfu This is ready for review

@Hugos68 Hugos68 changed the title Feat: twoslash-svelte feat: twoslash-svelte Mar 24, 2025
@PuruVJ
Copy link

PuruVJ commented Apr 5, 2025

Side comment, do remember to add svelte to dependencies or peers dependencies or devDependency :)

@Hugos68
Copy link
Author

Hugos68 commented Apr 5, 2025

@PuruVJ Good call! Thanks, will do.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants