WIP: 2.3.0 w/ Scala 2.11.12#29
Closed
psuter wants to merge 4 commits intotwosigma:2.3.0-cook-revert-antlr-4.7from
Closed
WIP: 2.3.0 w/ Scala 2.11.12#29psuter wants to merge 4 commits intotwosigma:2.3.0-cook-revert-antlr-4.7from
psuter wants to merge 4 commits intotwosigma:2.3.0-cook-revert-antlr-4.7from
Conversation
This reverts commit cde5492b227eb4a587e9bed2f2dcef754fc5415e.
This reverts commit 3d4892f1d4fe8556bdd010056df645f2f1aafe56.
icexelloss
force-pushed
the
2.3.0-cook-revert-antlr-4.7
branch
from
40269e9 to
543acdd
Compare
Author
|
Superseeded by #32 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This sets the Scala version to 2.11.12, which is advertised as compatible with Java 9. It also bumps a few related dependencies (most importantly JLine).
The patch is similar in spirit to apache#17982 and the only material change to the Spark codebase is to the REPL. The patch was created by looking at the 2.12 version of
SparkILoop.scala, as it appears the Scala compiler internal APIs are similar in2.11.{11,12}to2.12.x.How was this patch tested?
Project builds and all tests in
corepassed.There are new failures in the
replsuite, however, hence the WIP status. This may be related to this this comment by Iulian Dragos.