Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Scrollbar on table widget covers data #7685

Closed
benmccann opened this issue Jul 14, 2018 · 5 comments
Closed

Scrollbar on table widget covers data #7685

benmccann opened this issue Jul 14, 2018 · 5 comments
Assignees

Comments

@benmccann
Copy link
Contributor

Screenshot of the issue below. I can fix it by dragging the table to be wider, but it would be nice to have the default width be a bit larger

screenshot from 2018-07-12 23-04-26

@benmccann
Copy link
Contributor Author

Btw, another thing that would be a small nice tweak would be if the top of the scrollbar were better aligned with the table header. It's a little weird that I can scroll past the table header currently. Mostly cosmetic though...

@piorek
Copy link
Contributor

piorek commented Oct 19, 2018

@benmccann can you see if this issue still exists? In current master I get this:

image

@piorek
Copy link
Contributor

piorek commented Oct 19, 2018

@LeeTZ that scroll position could be tricky. Would have to analyse how phosphor/datagrid we are extending is handling that.

How should it look?
Horizontal scroll bar should be moved right by the width of left header.
Vertical scroll bar should be moved down by the height of top header.
How should the empty space we introduce this way look?

@benmccann
Copy link
Contributor Author

Ok, great. I will trust that it's fixed then

I was thinking that it could be nice to align the top of the scrollbar like the below image. I photoshopped your screenshot to demonstrate. See the top-right corner of the table

47217336-593df800-d3a8-11e8-9999-bbd8216d0780

@piorek
Copy link
Contributor

piorek commented Nov 19, 2018

@LeeTZ close this issue please

@piorek piorek removed their assignment Nov 29, 2018
@LeeTZ LeeTZ closed this as completed Dec 3, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants